Skip to content

De-duplicate pipeline steps in system.auth module#41229

Merged
belimawr merged 1 commit intoelastic:mainfrom
belimawr:41226-reduce-duplication-system-module-intest-pipelines
Oct 14, 2024
Merged

De-duplicate pipeline steps in system.auth module#41229
belimawr merged 1 commit intoelastic:mainfrom
belimawr:41226-reduce-duplication-system-module-intest-pipelines

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented Oct 14, 2024

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

## Author's Checklist

How to test this PR locally

Run the system tests

mage buildSystemTestBinary
mage docker:ComposeUp
source $(mage PythonVirtualEnv)/bin/activate
INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false ES_PASS=testing ES_USER=admin TESTING_FILEBEAT_MODULES=system pytest tests/system/test_modules.py

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr requested a review from leehinman October 14, 2024 17:20
@belimawr belimawr requested a review from a team as a code owner October 14, 2024 17:20
@belimawr belimawr requested a review from rdner October 14, 2024 17:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2024
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 14, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 14, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2024
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 14, 2024
@belimawr belimawr merged commit f69b501 into elastic:main Oct 14, 2024
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@belimawr @mergify
De-duplicate pipeline steps in system.auth module (#41229)
6ceb61b 
(cherry picked from commit f69b501)

# Conflicts:
#	filebeat/module/system/auth/ingest/entrypoint.yml
#	filebeat/module/system/auth/ingest/journald.yml
#	filebeat/module/system/auth/manifest.yml
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
1 task
belimawr added a commit that referenced this pull request Oct 15, 2024
@belimawr
De-duplicate pipeline steps in system.auth module (#41229)
fd43f83 
(cherry picked from commit f69b501)
belimawr added a commit that referenced this pull request Oct 15, 2024
@mergify @belimawr
De-duplicate pipeline steps in system.auth module (#41229) (#41231)
f1359c8 
(cherry picked from commit f69b501)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
@belimawr belimawr deleted the 41226-reduce-duplication-system-module-intest-pipelines branch December 19, 2024 13:55
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@belimawr belimawr

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce ingest pipeline duplication in Filebeat's system module

3 participants

@belimawr @elasticmachine @leehinman